[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

This revision was automatically updated to reflect the committed changes. Closed by commit rG14ae5d2b745f: [HLSL] Add SV_DispatchThreadID (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz accepted this revision. beanz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468706. python3kgae added a comment. More check on the ir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468700. python3kgae added a comment. Check sret parameter exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clan

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 466141. python3kgae marked 5 inline comments as done. python3kgae added a comment. Fix test fail after rebase and code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ ht

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:135 +llvm::Function *DxThreadID = CGM.getIntrinsic(Intrinsic::dx_thread_id); +// dx_thread_id +return buildVectorInput(B, DxThreadID, Ty); nit: this comment doesn't add value

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto &Param : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. beanz wrote: > python3kgae wrote: > > beanz wrote: > > > I might

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 464392. python3kgae marked an inline comment as done. python3kgae added a comment. Insert position value for sret output to make a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://rev

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto &Param : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. python3kgae wrote: > beanz wrote: > > I might be missing something, bu

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto &Param : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. beanz wrote: > I m

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto &Param : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. I might be missing something, but I'm not seeing a test that exercises

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 464354. python3kgae marked an inline comment as done. python3kgae added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/includ

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a think-o that I introduced with an earlier suggested change. I'm not super qualified for the CodeGen changes. They look correct to me, but @beanz would probably

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added a comment. In D133983#3808302 , @aaron.ballman wrote: > In D133983#3807284 , @python3kgae > wrote: > >> In D133983#3805761 , >> @aaron.ballman wrote:

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462311. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462308. python3kgae marked 8 inline comments as done. python3kgae added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman added a comment. In D133983#3807284 , @python3kgae wrote: > In D133983#3805761 , @aaron.ballman > wrote: > >> There are no tests for applying this to a global variable, so those should >> be added

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added a comment. In D133983#3805761 , @aaron.ballman wrote: > There are no tests for applying this to a global variable, so those should be > added. The global variable in the Subjects is wrong. It should be Field. Support for semantic on f

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462039. python3kgae marked 4 inline comments as done. python3kgae added a comment. Add type check for dispatch thread id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman added a comment. There are no tests for applying this to a global variable, so those should be added. Comment at: clang/include/clang/Basic/AttrDocs.td:6596-6598 +The ``SV_DispatchThreadID`` semantic, when applied to an input parameter, specifies a +data binding

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 461151. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 460546. python3kgae added a comment. Fix warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/include/clang

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: