[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

2022-09-06 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D133358#3773210 , @MaskRay wrote: > Python 3.7 can use `subprocess.run` with `capture_output`: > https://docs.python.org/3/library/subprocess.html#:~:text=capture_output Well, if you wanted to avoid calling `subprocess.Popen()

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

2022-09-06 Thread Michał Górny via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea953b9d9a65: [compiler-rt] [test] Handle missing ld.gold gracefully (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscri

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

2022-09-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Python 3.7 can use `subprocess.run` with `capture_output`: https://docs.python.org/3/library/subprocess.html#:~:text=capture_output But llvm-project requires Python >= 3.6 now, so we have to

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

2022-09-06 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. After reviewing this, please also approve backport to 15.x in https://github.com/llvm/llvm-project/issues/57580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133358/new/ https://reviews.llvm.org/D133358 ___ cfe-commi

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

2022-09-06 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: MaskRay, myhsu, vsk. Herald added subscribers: Enna1, StephenFan, dberris. Herald added a project: All. mgorny requested review of this revision. Fix the is_binutils_lto_supported() function to handle missing executables gracefully. Currently,