MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Python 3.7 can use `subprocess.run` with `capture_output`: 
https://docs.python.org/3/library/subprocess.html#:~:text=capture_output

But llvm-project requires Python >= 3.6 now, so we have to stay with `Popen`. 
Technically `OSError` can be `FileNotFoundError` if you want to be more 
specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133358/new/

https://reviews.llvm.org/D133358

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to