[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG0c111dd86fff: [libc++] Documents details of the pre-commit CI. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D133249?vs=460827&id=4

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for all feedback! Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added inline comments. Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a regex in the + "expected" tests to make it pass the CI. +

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne accepted this revision. ldionne added inline comments. Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a regex in the + "expected" tests

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 460827. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: clan

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 24 inline comments as done. Mordante added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + th

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added inline comments. Comment at: clang/www/hacking.html:279 + + Some changes in Clang affect https://libcxx.llvm.org";>libc++, + for example: ldionne wrote: > This follows my previous comment, but we really don't want to encourage Clang > folks

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM w/ comments. Thanks a lot for writing this! Comment at: clang/www/hacking.html:279 + + Some changes in Clang affect https://libcxx.llvm.org";>libc++, + for example:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + Mordante wrote: > aaron.ballman wrote: > > mstorsjo wrote: > > > Mordante wrote: > > > > mstorsjo wrote: > > > > >

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459351. Mordante added a comment. Rebased to fix CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: clang/www/hacking.html libcxx/docs/Contributi

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added inline comments. Comment at: libcxx/docs/Contributing.rst:88 +* C++XX for the Linux platform (where XX is the latest C++ version). +* MacOS X86_64 and MacOS arm64 for the Apple platform. + philnik wrote: > They are synonyms, since use the undersco

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459347. Mordante marked 15 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: cla

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

zero9178 added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. +

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

tahonermann added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator.

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 8 inline comments as done. Mordante added a comment. Thanks for all review comments! I'm a bit out of time so I will look at the other comments later. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. T

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. + -

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. + -

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/www/hacking.html:33 Testing on the Command Line +Testing changes affecting libcxx Similar capitalization is used in the file. Comment at:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne added a comment. This is awesome. I have some comments, but I have not done an in-depth pass at this yet. Comment at: libcxx/docs/Contributing.rst:139 + +.. [#] There's `Dev meeting talk `__ + explaining the benefits of l

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + Mordante wrote: > mstorsjo wrote: > > I don't understand this paragraph - each CI run is run through the > > confi

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik accepted this revision as: philnik. philnik added a comment. Mostly LGTM. Just a few nits. Comment at: clang/www/hacking.html:276 + + Testing changes affecting libcxx + To make it consistent throughout Comment at: clang/www/hacki

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added a comment. Thanks for the review comments. I'll address them in a little while. I want to wait for more review comments. Comment at: clang/www/hacking.html:302 + + For most builds, the pre-commit CI uses a recent + https://apt.llvm.org/";>nightly build of Clan

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mizvekov added inline comments. Comment at: libcxx/docs/Contributing.rst:164-165 + + When this buld fails with an LLVM assertion, the crash diagnostics are + available as an artifact. + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: clang/www/hacking.html:302 + + For most builds, the pre-commit CI uses a recent + https://apt.llvm.org/";>nightly build of Clang from LLVM's main I'm wondering if there's a better synonym for "builds" here which would

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante created this revision. Mordante added reviewers: aaron.ballman, ldionne. Herald added subscribers: mstorsjo, arphaman. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Heral