This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tra marked an inline comment as done.
Closed by commit rG54c47ff9398f: [CUDA] Allow using -o with -fsyntax-only
(authored by tra).
Repository:
rG LLVM Github Monorep
jhuber6 added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output:
(nothing)
//
// Test two gpu architectures up to the assemble phase.
tra wrote:
> tra wrote:
> > yaxunl w
tra marked an inline comment as done.
tra added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output:
(nothing)
//
// Test two gpu architectures up to the assemble phase.
tr
tra updated this revision to Diff 457377.
tra added a comment.
Updated tests and addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133133/new/
https://reviews.llvm.org/D133133
Files:
clang/lib/Driver/Driver.cpp
clang/test/Drive
tra added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output:
(nothing)
//
// Test two gpu architectures up to the assemble phase.
yaxunl wrote:
> should we check there is
yaxunl added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output:
(nothing)
//
// Test two gpu architectures up to the assemble phase.
should we check there is no binding f
jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.
LG, thanks.
Comment at: clang/lib/Driver/Driver.cpp:4555
else if (A->getKind() == Action::OffloadClass &&
- A->getType() == types::TY_Nothing)
+
tra created this revision.
Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl.
Herald added a project: All.
tra updated this revision to Diff 457341.
tra added a comment.
tra updated this revision to Diff 457343.
tra published this revision for review.
tra added reviewers: jhuber6, yaxun
