tra marked an inline comment as done.
tra added inline comments.
================
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output:
(nothing)
//
// Test two gpu architectures up to the assemble phase.
----------------
tra wrote:
> yaxunl wrote:
> > should we check there is no binding for Assembler and Linker?
> @jhuber6 : Interestingly enough, this exposed what looks like an issue with
> the new driver -- it will apparently attempt to run linker on empty inputs.
> I believe it's an issue independent of this patch and will need to be fixed
> separately.
>
> ```
> bin/clang -target powerpc64le-ibm-linux-gnu -ccc-print-bindings -fsyntax-only
> --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_35 --offload-new-driver
> /usr/local/google/home/tra/work/llvm/repo/clang/test/Driver/cuda-bindings.cu
> # "nvptx64-nvidia-cuda" - "clang", inputs:
> ["clang/test/Driver/cuda-bindings.cu"], output: (nothing)
> # "nvptx64-nvidia-cuda" - "clang", inputs:
> ["clang/test/Driver/cuda-bindings.cu"], output: (nothing)
> # "nvptx64-nvidia-cuda" - "NVPTX::Linker", inputs: [(nothing), (nothing)],
> output: "/tmp/cuda-bindings-0bbbdf.fatbin"
> # "powerpc64le-ibm-linux-gnu" - "clang", inputs:
> ["clang/test/Driver/cuda-bindings.cu", "/tmp/cuda-bindings-0bbbdf.fatbin"],
> output: (nothing)
> ```
-fsyntax-only indeed crashes the new driver: https://godbolt.org/z/vqs4b8Mv1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133133/new/
https://reviews.llvm.org/D133133
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
