This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG463e30f51fd0: [Clang] Fix crash in coverage of if consteval.
(authored by cor3ntin).
Changed prior to commit:
https://reviews.llvm.org/D132723?vs=
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407
// The 'else' count applies to the area immediately after the 'then'.
cor3ntin updated this revision to Diff 455917.
cor3ntin added a comment.
Formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132723/new/
https://reviews.llvm.org/D132723
Files:
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/CoverageMapping
cor3ntin marked an inline comment as done.
cor3ntin added inline comments.
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407
// The 'else' count applies to the area immediately after the 'then'.
- Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else));
cor3ntin updated this revision to Diff 455883.
cor3ntin added a comment.
Release notes + style issues (There was no shadowing though)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132723/new/
https://reviews.llvm.org/D132723
Files:
clang/docs/Re
aaron.ballman added a comment.
Can you also add a release note?
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1375
extendRegion(S);
+
if (S->getInit())
Spurious whitespace change.
Comment at: clang/lib/CodeGen/CoverageMapping
cor3ntin added a comment.
@aaron.ballman I did a minimal fix, both because It's unclear to me how
coverage work and because I think we should try to land this is 15.
I hope that's okay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132723/new/
ht
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Clang crashes when encountering an `if consteval` statement.
This is the minimum fix not to crash.
The fix is consistent w
