cor3ntin marked an inline comment as done. cor3ntin added inline comments.
================ Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407 // The 'else' count applies to the area immediately after the 'then'. - Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else)); + auto Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else)); if (Gap) ---------------- aaron.ballman wrote: > 1) Pick a name which doesn't shadow > 2) Spell out the type instead of using `auto` `auto Gap...` was preexisting, I changed both instances. Both variables are in their own non nested scopes though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132723/new/ https://reviews.llvm.org/D132723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits