[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei added a comment. Thanks @RKSimon Comment at: clang/lib/Headers/immintrin.h:223 +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +(defined(__AVX512VL__) && defined(__AVX512FP16__)) #include RKSimon wrote: > (style)

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08388ad81e9d: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Headers/immintrin.h:223 +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +(defined(__AVX512VL__) && defined

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + pengfei wrote: > RKSimon wrote: > > Doesn't this have to be the general case like in other places in the > > headers? > > ``` > > #if !(defined(_MSC_VER) || d

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + RKSimon wrote: > Doesn't this have to be the general case like in other places in the headers? > ``` > #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_fe

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + Doesn't this have to be the general case like in other places in the headers? ``` #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei updated this revision to Diff 454475. pengfei added a comment. Rebased on D132372 . > Should the const change be a separate patch? They feel unrelated. Done. The change results in lit test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

craig.topper added a comment. Should the const change be a separate patch? They feel unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132342/new/ https://reviews.llvm.org/D132342 ___ cfe-commits

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei updated this revision to Diff 454362. pengfei added a comment. Don't know why, but check `!defined(__SSE2__)` leads to compiler_builtins_x86.c fails like below. Move the check into avx512[vl]fp16intrin.h instead. error: 'error' diagnostics seen but not expected: File /export/users

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei created this revision. pengfei added reviewers: LuoYuanke, craig.topper, yubing, RKSimon, skan, FreddyYe. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. S