RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/lib/Headers/immintrin.h:223 +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ + (defined(__AVX512VL__) && defined(__AVX512FP16__)) #include <avx512vlfp16intrin.h> ---------------- (style) - other uses in this header put the defined(__AVX512VL__) after: ``` (defined(__AVX512FP16__) && defined(__AVX512VL__)) ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132342/new/ https://reviews.llvm.org/D132342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits