[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3dd10a8b48: [clang-format] Concepts: allow identifiers after negation (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG LLVM

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Please state a name and email for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 ___ cfe-commits mailing list c

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

curdeius accepted this revision. curdeius added a comment. @rymiel, please provide your name and email address for the commit message, so that it can land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.o

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. In D131978#3729644 , @rymiel wrote: > It seems that even with this patch, there is seemingly weird formatting with > the negation in requires clauses, such as: > > template > requires !F > int bar(T

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. It seems that even with this patch, there is seemingly weird formatting with the negation in requires clauses, such as: template requires !F int bar(T t); This is because the "fake parens" of the unary expression opened is never closed by the special

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. In D131978#3727110 , @HazardyKnusperkeks wrote: > It's late (where I am). I thought we had something like > `ClosesRequiresClause` for concepts too. > But on the other hand, this should affect requires clauses, right? So a test

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D131978#3727084 , @rymiel wrote: > Added negation unary operator check to TokenAnnotatorTest > > Is this what you meant? Alt

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel updated this revision to Diff 453107. rymiel added a comment. Added negation unary operator check to TokenAnnotatorTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 Files: clang/lib/Format/Unw

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Nice patch. Could you please also extend the test in `TokenAnnotatorTests.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel created this revision. rymiel added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the formatter would refuse to treat