This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb3f1a6bf1080: [clang][dataflow] Encode options using
llvm::Optional (authored by samestep).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
samestep updated this revision to Diff 452196.
samestep added a comment.
Remove unnecessary explicit call to hasValue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131779/new/
https://reviews.llvm.org/D131779
Files:
clang/include/clang/Analysis/
samestep added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:70
+ ? TransferOptions{}
+ : llvm::Optional()}) {}
sgatev wrote:
>
I tried tha
samestep updated this revision to Diff 452193.
samestep added a comment.
Use llvm::None per Gábor's suggestion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131779/new/
https://reviews.llvm.org/D131779
Files:
clang/include/clang/Analysis/FlowSen
sgatev accepted this revision.
sgatev added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:70
+ ? TransferOptions{}
+
xazax.hun added a comment.
LLVM switched to C++17 recently. I am not sure whether this means
`std::optional` is preferred over `llvm::Optional`.
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3902
},
- {/*.ApplyBuiltinTransfer=*
samestep created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
samestep requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https:/
