[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8655f7ff286: [clang-tidy] Improve modernize-use-emplace check (authored by joeywatts, committed by njames93). Changed prior to commit: https://reviews.llvm.org/D131623?vs=451960&id=453899#toc Reposito

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. In D131623#3731106 , @njames93 wrote: > In D131623#3730833 , @joeywatts > wrote: > >> Thanks for the review @njames93! This is my first contribution so I don't >> think I have permissi

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

njames93 added a comment. In D131623#3730833 , @joeywatts wrote: > Thanks for the review @njames93! This is my first contribution so I don't > think I have permission to land this myself, is there someone that can do > that for me? Sure thing, In D131

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. Thanks for the review @njames93! This is my first contribution so I don't think I have permission to land this myself, is there someone that can do that for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ h

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts updated this revision to Diff 451960. joeywatts added a comment. Address code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ https://reviews.llvm.org/D131623 Files: clang-tools-extra/clang-tidy/modernize/UseE

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. In D131623#3716227 , @njames93 wrote: > Just a general drive by comment here and doesn't affect this patch. > This specifying containers logic is a little verbose, There may be a case to > deprecate most of these options and j

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

njames93 added a comment. Just a general drive by comment here and doesn't affect this patch. This specifying containers logic is a little verbose, There may be a case to deprecate most of these options and just detect containers with an equivalent emplace* method at runtime. ===

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts updated this revision to Diff 451850. joeywatts added a comment. Update commit title/message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ https://reviews.llvm.org/D131623 Files: clang-tools-extra/clang-tidy/modernize/UseEm

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. joeywatts updated this revision to Diff 451689. joeywatts added a comment. Eugene.Zelenko retitled this revision from "(wip) improve modernize-use-emplace check" to "[clang-tidy][wip] improve mo