[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f18f7c0072b: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay added a comment. In D131346#3706216 , @nemanjai wrote: > Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is > very clear and obvious. What do we gain by getting rid of it? > Don't get me wrong, I am not super opposed to

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

aaron.ballman added a comment. In D131346#3706216 , @nemanjai wrote: > Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is > very clear and obvious. What do we gain by getting rid of it? Less novel macro usage helps readability

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

nemanjai added a comment. Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is very clear and obvious. What do we gain by getting rid of it? Don't get me wrong, I am not super opposed to using a standard string instead of an LLVM-specific macro. However, it seems that th

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I assume you'll be removing the macro definition from Compiler.h once all the projects have been updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay created this revision. MaskRay added a reviewer: aaron.ballman. Herald added subscribers: steakhal, kosarev, pmatos, asb, StephenFan, martong, kerbowa, arphaman, kbarton, jgravelle-google, sbc100, jvesely, nemanjai, dschuff. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Her