[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

This revision was automatically updated to reflect the committed changes. Closed by commit rGad16268f1350: [Clang] Do not check for underscores in isAllowedInitiallyIDChar (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/n

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

tahonermann accepted this revision. tahonermann added a comment. LGTM, thanks Corentin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 ___ cfe-commits mailing

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming @tahonermann doesn't spot concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.o

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1486 static bool isAllowedInitiallyIDChar(uint32_t C, const LangOptions &LangOpts) { + assert(C > 0x7F && "isAllowedInitiallyIDChar called with a non-ASCII codepoint"); if (LangOpts.AsmPreprocessor) { -

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin updated this revision to Diff 448581. cor3ntin added a comment. Fix asser message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 Files: clang/lib/Lex/Lexer.cpp Index: clang/lib/Lex/Lexer.cpp

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

aaron.ballman added a comment. The change is fine by me, but you should put NFC in the patch title so it's more clear that this is simplifying code in a way that won't change behavior (and doesn't need tests). Comment at: clang/lib/Lex/Lexer.cpp:1486 static bool isAllowedIni

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. isAllowedInitiallyIDChar is only used with non-ASCII codepoints, which are handled by isAsciiIdentifierStart. To make that