Re: [PATCH] D13048: Fix for merging decls in pragma weak

This revision was automatically updated to reflect the committed changes. Closed by commit rL254143: Fix for merging decls in pragma weak (authored by amusman). Changed prior to commit: http://reviews.llvm.org/D13048?vs=35348&id=41216#toc Repository: rL LLVM http://reviews.llvm.org/D13048

Re: [PATCH] D13048: Fix for merging decls in pragma weak

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D13048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D13048: Fix for merging decls in pragma weak

aaron.ballman added a comment. Generally LGTM, but I would wait for Richard to review in this case. ~Aaron Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to CheckFu

Re: [PATCH] D13048: Fix for merging decls in pragma weak

amusman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to CheckFunctionDeclaration(). // FIXME: Mangling? // FIXME: Is the qualifier i

Re: [PATCH] D13048: Fix for merging decls in pragma weak

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to CheckFunctionDeclaration(). // FIXME: Mangling? // FIXME: Is the quali

[PATCH] D13048: Fix for merging decls in pragma weak

amusman created this revision. amusman added reviewers: rsmith, aaron.ballman, ABataev. amusman added a subscriber: cfe-commits. In the following example, we have a declaration of weakfoo before #pragma weak. extern void weakfoo(); void localfoo() { }