aaron.ballman added a comment.
Generally LGTM, but I would wait for Richard to review in this case.
~Aaron
================
Comment at: lib/Sema/SemaDeclAttr.cpp:5201
@@ -5200,5 +5200,3 @@
if (FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
- FunctionDecl *NewFD;
- // FIXME: Missing call to CheckFunctionDeclaration().
// FIXME: Mangling?
// FIXME: Is the qualifier info correct?
----------------
amusman wrote:
> aaron.ballman wrote:
> > If we're in this code, any chance you can also look at the other FIXME
> > statements? If not, that's fine -- this is still positive movement. But
> > it's usually best to tackle all of these at once while it's fresh in
> > someone's mind what's happening here.
> I've got here through an existing test case that failed on assertion, not
> sure I can quickly write or find examples for the other fixme's... So, I'd
> prefer not to promise that :)
>
Ah, I hadn't noticed that this was Eli's code originally. I thought the
original author was on the review thread for context. I wouldn't worry about
it. If it's not problems in the last four years, we can live with it for a bit
longer. ;-)
http://reviews.llvm.org/D13048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
