[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

2022-07-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG1515490c80fa: [clangd] Mention whether compile flags were inferred in check mode (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D130

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

2022-07-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Please note the NIT that arguably improves readability. Comment at: clang-tools-extra/clangd/tool/Check.cpp:114 Cmd = std::move(*TrueCmd); - l

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

2022-07-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. That way when