kadircet added a comment.
no worries, as discussed offline this LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
___
cfe-commits mailing list
cfe-commits@list
dgoldman added a comment.
Ah my bad didn't realize you hadn't accepted this, was there anything else you
wanted me to change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
_
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61ef0ab70196: [clangd] Add decl/def support to SymbolDetails
(authored by dgoldman).
Repository:
rG LLVM Github Monorep
dgoldman updated this revision to Diff 449050.
dgoldman added a comment.
Run clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
Files:
clang-tools-extra/clangd/AST.cpp
clang-tools-extra/clan
dgoldman updated this revision to Diff 449033.
dgoldman added a comment.
Fix broken test and swap to AST.tuPath()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
Files:
clang-tools-extra/clangd/AST.cpp
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1528
}
-
+ auto MainFilePath =
+ getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM);
dgoldman wrote:
> dgoldman wrote:
> > sammccall wrote:
> > > kadircet wrote:
>
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1528
}
-
+ auto MainFilePath =
+ getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM);
dgoldman wrote:
> sammccall wrote:
> > kadircet wrote:
> > > let's just pass t
dgoldman updated this revision to Diff 447813.
dgoldman added a comment.
Run clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
Files:
clang-tools-extra/clangd/AST.cpp
clang-tools-extra/clan
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1528
}
-
+ auto MainFilePath =
+ getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM);
sammccall wrote:
> kadircet wrote:
> > let's just pass the TUPath from ClangdS
dgoldman updated this revision to Diff 447771.
dgoldman marked 5 inline comments as done.
dgoldman added a comment.
Minor fixes for review (some still pending based on discussion)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://re
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1528
}
-
+ auto MainFilePath =
+ getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM);
kadircet wrote:
> let's just pass the TUPath from ClangdServer into the reque
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:174
auto L = D.getLocation();
+ // Use the start of the first selector fragment instead of the -/+ location.
+ if (const auto *MD = dyn_cast(&D))
kadircet wrote:
> can we do this in
kadircet added a comment.
thanks, this LG per symboldetails change but as discussed offline i think we
actually need a new request or a capability to indicate this (and having a new
request is just easier for both clients and clangd) otherwise it can't be
reliably used by clients.
in addition
dgoldman added a comment.
For more context see the discussion on b/187405187
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
___
cfe-commits mailing list
cfe-co
dgoldman updated this revision to Diff 445618.
dgoldman added a comment.
Revert unintended change in symbol-info.test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130041/new/
https://reviews.llvm.org/D130041
Files:
clang-tools-extra/clangd/AST.
dgoldman created this revision.
dgoldman added reviewers: kadircet, sammccall.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-e
16 matches
Mail list logo