[PATCH] D129104: [Modules] Add ODR Check for concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b95a5a77253: [Modules] Add ODR Check for concepts (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443961. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTCo

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:187 +- Clang now would check ODR violations when merging concepts from different modules. + Note that it may break existing codes and the behavior is intended. + Fixes `Issue 56310

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/docs/ReleaseNotes.rst:187 +- Clang now would check ODR violations when merging concepts from different modules. + Note that it may break existing codes and the behavior is intended. +

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443958. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_diffe

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 template function. Fixes `Issue 55560 `_. +- Clang now would check ODR violations when merging concepts from different modules. + Note that it ma

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443957. ChuanqiXu added a comment. Add ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_diffe

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added a comment. Thanks for reviewing and noting! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added a comment. Should have a release note on commit! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing l

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added a comment. @erichkeane @ilya-biryukov gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6533 + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl without constraint expression?"); + llvm::FoldingSetNod

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6532 + const Expr *XCE = ConceptX->getConstraintExpr(); + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl wihtout constraint expression?"); --

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 442425. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_differ.cpp clang/test/Modules/con

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6532 + const Expr *XCE = ConceptX->getConstraintExpr(); + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl wihtout constraint expression?"); -

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 442179. ChuanqiXu added a comment. Undo the format test. It breaks the testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_differ.c

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu created this revision. ChuanqiXu added reviewers: ilya-biryukov, erichkeane, vsapsai, rsmith. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closing