erichkeane added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:187 +- Clang now would check ODR violations when merging concepts from different modules. + Note that it may break existing codes and the behavior is intended. + Fixes `Issue 56310 <https://github.com/llvm/llvm-project/issues/56310>`_. ---------------- ChuanqiXu wrote: > erichkeane wrote: > > > Although as a non-native speaker, the current wording looks like the new > clang is going to break existing code and what I want to say it is only > **possible**. > > I followed your suggestion since I feel it might not be meaningful to argue > English with a native speaker : ) Hmm, you're right about that being a subtlety that I didn't pick up. We could consider changing 'expected to' to 'likely to', or replace 'is expected to' could be 'may' (or even 'may possibly') depending on your confidence :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
