This revision was automatically updated to reflect the committed changes.
Closed by commit rG6db0c18b1af6: [clang-format] Handle Verilog modules
(authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128712/new/
https://reviews.llvm.org
sstwcw marked 2 inline comments as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4072
+Keywords.kw_randsequence)) {
+AddLevels += Style.IndentCaseLabels;
+nextToken();
HazardyKnusp
sstwcw updated this revision to Diff 443791.
sstwcw added a comment.
- take out check
- use boolean as boolean
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128712/new/
https://reviews.llvm.org/D128712
Files:
clang/lib/Format/FormatToken.h
cla
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4040
+void UnwrappedLineParser::parseVerilogSensitivityList() {
+ if (!FormatTok->is(tok::at))
+return;
I prefer to make such checks before calling the function.
B
sstwcw updated this revision to Diff 443605.
sstwcw edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128712/new/
https://reviews.llvm.org/D128712
Files:
clang/lib/Format/FormatToken.h
clang/lib/Format/TokenAnnot
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/FormatToken.h:1742
+ /// Returns whether \p Tok is a Verilog keyword that opens a module, etc.
+ bool isVerilogHier(const FormatToken &Tok) const {
+if (Tok.endsSequence(kw_function, kw_with))
--
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Now things inside hierarchies like modules and
