[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + Hahnfeld wrote: > I think i

[PATCH] D128589: [clang-repl] Support destructors of global objects.

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + I think it would be bett

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho added a comment. This seems to be breaking builds in ppc bots. Invastigating right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://reviews.llvm.org/D128589 ___ cfe-commits ma

[PATCH] D128589: [clang-repl] Support destructors of global objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9de8b05bfe0d: [clang-repl] Support destructors of global objects. (authored by sunho). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://rev

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho updated this revision to Diff 440047. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://reviews.llvm.org/D128589 Files: clang/lib/Interpreter/IncrementalExecutor.cpp clang/lib/Interpreter/IncrementalExecutor.h clang/lib/Interpreter/Interpreter.cpp clang/test

[PATCH] D128589: [clang-repl] Support destructors of global objects.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, modulo the comment. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:46 llvm::Error runCtors() const; + llvm::Error cleanUp(); llvm::Expected