ymandel added a comment.
This looks quite nice. I really like how you solved the problem of diagnostics
representation/checking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128446/new/
https://reviews.llvm.org/D128446
_
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp:1258
+
+ llvm::DenseSet AnnotationLines;
+ for
samestep updated this revision to Diff 439415.
samestep added a comment.
- Merge branch 'diagnose-api' into diagnose-test-annotations
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128446/new/
https://reviews.llvm.org/D128446
Files:
clang/unittes
samestep created this revision.
Herald added subscribers: martong, tschuett, xazax.hun.
Herald added a project: All.
samestep requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D1
