[PATCH] D127812: [AArch64] Function multiversioning support added.

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:188 +AARCH64_CPU_FEATURE("sve_aes",SVE_AES, "+sve2-aes", 330) +AARCH64_CPU_FEATURE("sve_pmull128", SVE_PMULL128, "", 340) +AARCH64_CPU_FEATURE("sve_bitperm",

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss requested changes to this revision. danielkiss added a comment. This revision now requires changes to proceed. Please find the thread on the GCC mailing list here: https://gcc.gnu.org/pipermail/gcc/2022-July/239134.html Feedback there sounds positive to me. All received feedback added

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:74 +def FeatureFMV : SubtargetFeature<"fmv", "HasFMV", "true", + "Enable Function Multi Versioning support.">; echristo wrote: > What is this for? FMV is a target feature which is ena

[PATCH] D127812: [AArch64] Function multiversioning support added.

echristo added a comment. In D127812#3616603 , @danielkiss wrote: > In D127812#3602688 , @aaron.ballman > wrote: > >> In D127812#3602645 , @erichkeane >> wrote: >> >>>

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss added a comment. In D127812#3602688 , @aaron.ballman wrote: > In D127812#3602645 , @erichkeane > wrote: > >> In D127812#3601476 , @danielkiss >> wrote: >> >>

[PATCH] D127812: [AArch64] Function multiversioning support added.

samtebbs added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11483 +def warn_target_clone_no_impact_options +: Warning<"version list contains no code impact entries">, + InGroup; ilinpv wrote: > erichkeane wrote: > > I'm n

[PATCH] D127812: [AArch64] Function multiversioning support added.

aaron.ballman added a comment. In D127812#3602645 , @erichkeane wrote: > In D127812#3601476 , @danielkiss > wrote: > >> Your understanding is correct. `target` attribute has two usage model. One >> is just rede

[PATCH] D127812: [AArch64] Function multiversioning support added.

erichkeane added a comment. In D127812#3601476 , @danielkiss wrote: > In D127812#3599530 , @aaron.ballman > wrote: > >> In D127812#3587223 , @ilinpv wrote: >> >>> In D12

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss added a comment. In D127812#3599530 , @aaron.ballman wrote: > In D127812#3587223 , @ilinpv wrote: > >> In D127812#3585249 , @erichkeane >> wrote: >> >>> I'm c

[PATCH] D127812: [AArch64] Function multiversioning support added.

aaron.ballman added a comment. In D127812#3587223 , @ilinpv wrote: > In D127812#3585249 , @erichkeane > wrote: > >> I'm concerned as to the design of this addition, I don't particularly >> appreciate the reasons

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + xbolva00 wrote: > ilinpv wrote: > > MaskRay wrote: > > > This file is auto-generated. Don't touch it. > > It looked out of sync with options td files

[PATCH] D127812: [AArch64] Function multiversioning support added.

xbolva00 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + ilinpv wrote: > MaskRay wrote: > > This file is auto-generated. Don't touch it. > It looked out of sync with options td files: > > ``` > +.. optio

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3090 + std::vector + filterFunctionTargetVersionAttrs(const TargetVersionAttr *TV) const; erichkeane wrote: > It is concerning that this differs from the above. target_version su

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + MaskRay wrote: > This file is auto-generated. Don't touch it. It looked out of sync with options td files: ``` +.. option:: -gen-reproducer=, -fno-c

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added a comment. In D127812#3585249 , @erichkeane wrote: > I'm concerned as to the design of this addition, I don't particularly > appreciate the reasons for making 'target_clones' different, nor the purpose > for adding a new attribute instead

[PATCH] D127812: [AArch64] Function multiversioning support added.

erichkeane added a comment. I'm concerned as to the design of this addition, I don't particularly appreciate the reasons for making 'target_clones' different, nor the purpose for adding a new attribute instead of using 'target' for what seems like exactly that? IF the new spelling is THAT nece

[PATCH] D127812: [AArch64] Function multiversioning support added.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + This file is auto-generated. Don't touch it. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1173 return None; - case ARM::BI_B