dmgreen added inline comments.
================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:188
+AARCH64_CPU_FEATURE("sve_aes", SVE_AES, "+sve2-aes", 330)
+AARCH64_CPU_FEATURE("sve_pmull128", SVE_PMULL128, "<NS>", 340)
+AARCH64_CPU_FEATURE("sve_bitperm", SVE_BITPERM, "+sve2-bitperm", 350)
----------------
The compiler already has names for these, used in the existing -march=...
options and target(...) attributes. It would be better to not have to invent a
new set of names that is slightly different.
It would be good if this could be combined with the table above too. Hopefully
it is just an expansion to the values already present.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127812/new/
https://reviews.llvm.org/D127812
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
