[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG96ccb690a0ef: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127742/n

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D127742#3582236 , @steakhal wrote: > In D127742#3581874 , @martong wrote: > >> Why not replace all `getA

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

steakhal added a comment. In D127742#3581874 , @martong wrote: > Why not replace all `getAs`? That's a massive change. I actually experimented with it and I see no advantage with that. > I suppose you picked conditions because `isa` can have variadic p

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

martong added a comment. Why not replace all `getAs`? I suppose you picked conditions because `isa` can have variadic parameters. If we are about to keep `getAs` then why not replace only those occurrences where we see the benefit of the variadic `isa`? Repository: rG LLVM Github Monorepo

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steak