[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. @a4lg If we have decided NOT to do this can we Abandon the review so as to remove it from the reviewers "clang-format" lists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D12748

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3576061 , @a4lg wrote: > Interesting. > > I measured some development branch (targeting `*.c`, `*.cc`, `*.cpp` and > `*.h`): > > | Program | prefix: 8 spaces | prefix: 1 tab | 8sp percentage | > | Coreutils | 23494

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg marked an inline comment as done. a4lg added a comment. Interesting. I measured some development branch (targeting `*.c`, `*.cc`, `*.cpp` and `*.h`): | Program | prefix: 8 spaces | prefix: 1 tab | 8sp percentage | | Coreutils | 23494| 461 | 98.08% | | Binutil

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. We get heavily criticized for changing defaults between versions, I think if someone want to use GNU style, and they choose to now have this option set it should be done so in their own .clang-format file On reflection, I think its wrong of us to change that now

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3574803 , @curdeius wrote: > It seems like a breaking change that may be painful for users of GNU style. Yeah. There are tens of thousands of lines starting with 8 spaces but none starting with a tab in all .c files u

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg updated this revision to Diff 436087. a4lg added a comment. Thanks, suggestion by @owenpan is applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484 Files: clang/lib/Format/Format.cpp clang/uni

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3574992 , @MyDeveloperDay wrote: > Oh gosh! It hard to make such changes and someone else not call them a > regression, I’m not sure how I feel. We do kind of have to be able to fix > bugs and if this gets closer to

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. Oh gosh! It hard to make such changes and someone else not call them a regression, I’m not sure how I feel. We do kind of have to be able to fix bugs and if this gets closer to gnu style then I guess it’s better Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D127484: [clang-format] Use tabs on GNU style

curdeius added a comment. It seems like a breaking change that may be painful for users of GNU style. @mydeveloperday, wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484 __

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg created this revision. Herald added a project: All. a4lg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On default configuration of GNU Indent, it uses 8-width tabs. Because GNU Indent's indentation works like UT_ForContinuationAndIn