This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
martong marked 2 inline comments as done.
Closed by commit rG2df120784af4: [analyzer] Fix assertion in simplifySymbolCast
(authored by martong).
Repository:
rG LLVM
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082
+ // FIXME support cast from non-integers.
+ // E.g (char)(double)(double x) -> (char)(double x)
+
martong marked 2 inline comments as done.
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082
+ // FIXME support cast from non-integers.
+ // E.g (char)(double)(double x) -> (char)(double x)
+ if (!RT->isIntegralOrEnumerationType())
--
martong updated this revision to Diff 437938.
martong added a comment.
- Rebase on dependent patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126779/new/
https://reviews.llvm.org/D126779
Files:
clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
steakhal added a comment.
Oh I forgot to submit my review. My bad. Please investigate why we have two
double casts there.
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082
+ // FIXME support cast from non-integers.
+ // E.g (char)(double)(double x) -> (char)(dou
martong added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126779/new/
https://reviews.llvm.org/D126779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
martong created this revision.
martong added reviewers: ASDenysPetrov, steakhal, NoQ, vabridgers.
Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added
