[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

erichkeane added a comment. In D126642#3547496 , @sdesmalen wrote: > In D126642#3547284 , @erichkeane > wrote: > >> I'm not sure I'm grokking hte difference between the ExtraBitfields and >> ExtParamInfos here.

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen added a comment. In D126642#3547284 , @erichkeane wrote: > I'm not sure I'm grokking hte difference between the ExtraBitfields and > ExtParamInfos here. The reason I repurposed the bit was because I previously tried adding a bit to `unsigned

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

aaron.ballman added a comment. Thanks for this! I'm still thinking about the design for this, but spotted a few minor things that could be addressed in the meantime. Comment at: clang/include/clang/AST/Type.h:3801-3802 /// FunctionTypeBitfields. Aligned to alignof(void *) t

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

erichkeane added a comment. I'm not sure I'm grokking hte difference between the ExtraBitfields and ExtParamInfos here. Also, the 'hasBitfields' seems like the answer should just be 'no' in the case when its 'no'... Comment at: clang/include/clang/AST/Type.h:4103 bool has

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen added a comment. This patch follows from some discussion on D124998 as well as the need for more bits to represent future function type attributes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126642

[PATCH] D126642: [Clang] NFCI: Repurpose HasExtParameterInfos for HasExtraBitfields

sdesmalen created this revision. sdesmalen added reviewers: aaron.ballman, erichkeane, efriedma. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The FunctionTypeExtraBitfields is currently only availab