aaron.ballman added a comment.
Thanks for this! I'm still thinking about the design for this, but spotted a
few minor things that could be addressed in the meantime.
================
Comment at: clang/include/clang/AST/Type.h:3801-3802
/// FunctionTypeBitfields. Aligned to alignof(void *) to maintain the
/// alignment of subsequent objects in TrailingObjects. You must update
/// hasExtraBitfields in FunctionProtoType after adding extra data here.
struct alignas(void *) FunctionTypeExtraBitfields {
----------------
It looks like this comment is now out of date.
================
Comment at: clang/include/clang/AST/Type.h:3810
+ /// Whether this function has extended parameter information.
+ bool HasExtParameterInfos : 1;
+
----------------
More forward-looking given that `NumExceptionType` really should be an 8-bit
wide bit-field.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126642/new/
https://reviews.llvm.org/D126642
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
