[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall added a comment. In D126397#3547438 , @sammccall wrote: > In D126397#3547060 , @thakis wrote: > >> Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's >> basically the same situation. >

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3547060 , @thakis wrote: > Even after this, you still have to explicitly set > `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. > Given that the host and target systems are both mac, that's a

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall added a comment. In D126397#3547060 , @thakis wrote: > Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's basically > the same situation. Yes, I agree, it should. I'll send a patch. One caveat here: that there are (too) many p

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

thakis added a comment. Even after this, you still have to explicitly set `-DCMAKE_SYSTEM_NAME=Darwin` when building clang for mac/arm on mac/intel. Given that the host and target systems are both mac, that's a bit weird. llvm-tblgen doesn't need this, it just works as long as you set `LLVM_USE

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

hans added a comment. This didn't fix the mac/arm64 llvm builds for Chromium. I think it's because we don't set CMAKE_CROSSCOMPILING, so I'll try doing that as a work-around. (crbug.com/1330304). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12639

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

mstorsjo added a comment. Regarding building native tools while cross compiling - for other tools so far, we’ve also had the option to pass an option like `-DLLVM_TABLEGEN=path/to/llvm-tblgen`. If all the needed native tools are provided that way, the build doesn’t need to set up the nested nat

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

hokein added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126397/new/ https://reviews.llvm.org/D126397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4baae166ce33: [pseudo] Fix pseudo-gen usage when cross-compiling (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126397/new/ https://re

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3537843 , @sammccall wrote: > Thank you! I have been banging my head against this, I'm not entirely sure > why this works and my version doesn't. Ah, sorry for the duplicated work :( Thanks for the review! Repositor

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! I have been banging my head against this, I'm not entirely sure why this works and my version doesn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai created this revision. smeenai added reviewers: hokein, sammccall. Herald added a subscriber: mgorny. Herald added a project: All. smeenai requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Use the LLVM build s