[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

2022-06-01 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, benshi001 wrote: >

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

2022-06-01 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. It seems that the expected path should be `$resource_dir/lib/avr5/libclang_rt.builtins.a`, other than `libclang_rt.builtins-avr5.a`. I will fix that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

2022-05-24 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, This method decides

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

2022-05-24 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 431665. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

2022-05-24 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. Repository: