[PATCH] D126183: Implement soft reset of the diagnostics engine.

mstorsjo added a comment. FYI, this change caused warnings when built with GCC: [1/1] Building CXX object tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/DiagnosticTest.cpp.o ../tools/clang/unittests/Basic/DiagnosticTest.cpp:17:6: warning: ‘void clang::DiagnosticsTestHelper(clang::Dia

[PATCH] D126183: Implement soft reset of the diagnostics engine.

This revision was automatically updated to reflect the committed changes. Closed by commit rG946c45a4ed5d: Implement soft reset of the diagnostics engine. (authored by tapaswenipathak, committed by v.g.vassilev). Changed prior to commit: https://reviews.llvm.org/D126183?vs=436750&id=439757#toc

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 436750. tapaswenipathak edited the summary of this revision. tapaswenipathak added a comment. Addresses review comment by @v.g.vassilev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:200 // FIXME: Do not reset the pragma handlers. +Diags.Reset(true); We should remove this fixme, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. This looks good to me, modulo the inline comment. Let's wait for @rsmith's green light. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:201 // FIXME

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 433362. tapaswenipathak added a comment. this should be green. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432747. tapaswenipathak added a comment. runs `make check-clang`, `check-clang-tools`, `check-all`. prev ran: `make check-clang-unit`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432730. tapaswenipathak added a comment. Fixes: https://buildkite.com/llvm-project/premerge-checks/builds/95001#01810b0b-6313-400f-aaf0-35855916ec93 I pasted the wrong diff. sorry! (have multiple build repository in local) F23230857: Screenshot 202

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432723. tapaswenipathak added a comment. Fixes F23230194: Screenshot 2022-05-28 at 7.18.51 PM.png . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432712. tapaswenipathak added a comment. runs clang-format on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: include/clang/Basic/Diagnosti

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432711. tapaswenipathak added a comment. Addresses review comment by @rsmith: https://reviews.llvm.org/D126183#3534846. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org

[PATCH] D126183: Implement soft reset of the diagnostics engine.

rsmith added a comment. I don't think we can live with the `#define private public` approach, not least because this violates the ODR and might lead to compile failures using modules as a result. As an alternative, how about: - Adding a `friend void DiagnosticTestHelper();` declaration to `Dia