mstorsjo added a comment. FYI, this change caused warnings when built with GCC:
[1/1] Building CXX object tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/DiagnosticTest.cpp.o ../tools/clang/unittests/Basic/DiagnosticTest.cpp:17:6: warning: ‘void clang::DiagnosticsTestHelper(clang::DiagnosticsEngine&)’ has not been declared within ‘clang’ 17 | void clang::DiagnosticsTestHelper(DiagnosticsEngine &diag) { | ^~~~~ In file included from ../tools/clang/unittests/Basic/DiagnosticTest.cpp:9: ../tools/clang/include/clang/Basic/Diagnostic.h:548:15: note: only here as a ‘friend’ 548 | friend void DiagnosticsTestHelper(DiagnosticsEngine &); | ^~~~~~~~~~~~~~~~~~~~~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits