[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG186bea3750d6: [MSVC] Add initial support for MSVC pragma optimize (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 439738. steplong added a comment. - Run pre-merge checks again after abandoning dependent patch D126984 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://rev

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 ___ cfe-commits mailing list cfe-comm

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 439097. steplong added a comment. - Fix up docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3798 +``#pragma optimize("[optimization-list]", on | off)``. At the moment, Clang only +supports an empty optimization list, whereas MSVC supports the parameters, ``s``, +``g``, ``t``, and ``y``.

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong added a comment. Hi, I'll land this on Friday. Let me know if there are any comments. Also, I'm not sure how to rebase it on top of main. At the moment, it's still on top of D126984 (i.e. stack has one open) Repository: rG LLVM Github Monorepo CHA

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437280. steplong added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3800 +``g``, ``t``, and ``y``. Clang's current implementation of the pragma behaves in +the same way as the clang pragma. All functions between ``off`` and ``on`` will +be decorated with the ``optnone`

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added a comment. Thanks Comment at: clang/docs/LanguageExtensions.rst:3800 +``g``, ``t``, and ``y``. Clang's current implementation of the pragma behaves in +the same way as the clang pragma. All functions between ``off`` and ``on`` will +be decorated with the ``optno

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437260. steplong added a comment. - Add documentation on difference btwn MSVC and Clang's implementation of pragma optimize Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. xbolva00 wrote: > xbolva00 wrote: > > So to sum up.. #pragma optimize("", off) disables all opt

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. xbolva00 wrote: > So to sum up.. #pragma optimize("", off) disables all optimizations, right? >

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman added a comment. In D125723#3585788 , @xbolva00 wrote: > In D125723#3585726 , @aaron.ballman > wrote: > >> LGTM! But given the number of people who've expressed opinions on this, >> please wait a d

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added a comment. In D125723#3585726 , @aaron.ballman wrote: > LGTM! But given the number of people who've expressed opinions on this, > please wait a day or two before landing in case other reviewers have > additional feedback. In term of cod

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. So to sum up.. #pragma optimize("", off) disables all optimizations, right? #pragma optimize("

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! But given the number of people who've expressed opinions on this, please wait a day or two before landing in case other reviewers have additional feedback. Repository:

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437153. steplong added a comment. - Fix docs - Clean up code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:301 C linkage. +- Added support for a nonempty optimization list for MSVC's ``#pragma optimize``. + The pragma takes a list of optimizations to turn on or off which applies to ==