[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

2022-06-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf88150c48df: [pseudo] Fix the incorrect parameters-and-qualifiers rule. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

2022-06-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 434733. hokein added a comment. pull out a separate test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125479/new/ https://reviews.llvm.org/D125479 Files: clang-tools-extra/pseudo/lib/cxx.bnf clang-to

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

2022-06-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/glr.cpp:37 + +void foo2(int, ...); +// CHECK: declaration~simple-declaration := decl-specifier-seq init-declarator-l

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

2022-06-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. friendly ping. Comment at: clang-tools-extra/pseudo/test/glr.cpp:37 + +void foo2(int, ...); +// CHECK: declaration~simple-declaration := decl-specifier-seq init-declarator-list ; since we have the builtin pseudoCXX library now, we

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

2022-05-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The parenthese body should be `parameter-declaration-clause`, rather than `pa