hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra.
The parenthese body should be `parameter-declaration-clause`, rather than `parameter-declaration-list`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D125479 Files: clang-tools-extra/pseudo/lib/cxx.bnf clang-tools-extra/pseudo/test/glr.cpp Index: clang-tools-extra/pseudo/test/glr.cpp =================================================================== --- clang-tools-extra/pseudo/test/glr.cpp +++ clang-tools-extra/pseudo/test/glr.cpp @@ -33,3 +33,17 @@ // CHECK-NEXT: │ ├─( // CHECK-NEXT: │ └─) // CHECK-NEXT: └─; + +void foo2(int, ...); +// CHECK: declaration~simple-declaration := decl-specifier-seq init-declarator-list ; +// CHECK-NEXT: ├─decl-specifier-seq~VOID := +// CHECK-NEXT: ├─init-declarator-list~noptr-declarator := noptr-declarator parameters-and-qualifiers +// CHECK-NEXT: │ ├─noptr-declarator~IDENTIFIER := +// CHECK-NEXT: │ └─parameters-and-qualifiers := ( parameter-declaration-clause ) +// CHECK-NEXT: │ ├─( := +// CHECK-NEXT: │ ├─parameter-declaration-clause := parameter-declaration-list , ... +// CHECK-NEXT: │ │ ├─parameter-declaration-list~INT := +// CHECK-NEXT: │ │ ├─, := +// CHECK-NEXT: │ │ └─... := +// CHECK-NEXT: │ └─) := +// CHECK-NEXT: └─; := \ No newline at end of file Index: clang-tools-extra/pseudo/lib/cxx.bnf =================================================================== --- clang-tools-extra/pseudo/lib/cxx.bnf +++ clang-tools-extra/pseudo/lib/cxx.bnf @@ -409,7 +409,7 @@ noptr-declarator := noptr-declarator parameters-and-qualifiers noptr-declarator := noptr-declarator [ constant-expression_opt ] noptr-declarator := ( ptr-declarator ) -parameters-and-qualifiers := ( parameter-declaration-list_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt +parameters-and-qualifiers := ( parameter-declaration-clause_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt trailing-return-type := -> type-id ptr-operator := * cv-qualifier-seq_opt ptr-operator := &
Index: clang-tools-extra/pseudo/test/glr.cpp =================================================================== --- clang-tools-extra/pseudo/test/glr.cpp +++ clang-tools-extra/pseudo/test/glr.cpp @@ -33,3 +33,17 @@ // CHECK-NEXT: â ââ( // CHECK-NEXT: â ââ) // CHECK-NEXT: ââ; + +void foo2(int, ...); +// CHECK: declaration~simple-declaration := decl-specifier-seq init-declarator-list ; +// CHECK-NEXT: ââdecl-specifier-seq~VOID := +// CHECK-NEXT: ââinit-declarator-list~noptr-declarator := noptr-declarator parameters-and-qualifiers +// CHECK-NEXT: â âânoptr-declarator~IDENTIFIER := +// CHECK-NEXT: â ââparameters-and-qualifiers := ( parameter-declaration-clause ) +// CHECK-NEXT: â ââ( := +// CHECK-NEXT: â ââparameter-declaration-clause := parameter-declaration-list , ... +// CHECK-NEXT: â â ââparameter-declaration-list~INT := +// CHECK-NEXT: â â ââ, := +// CHECK-NEXT: â â ââ... := +// CHECK-NEXT: â ââ) := +// CHECK-NEXT: ââ; := \ No newline at end of file Index: clang-tools-extra/pseudo/lib/cxx.bnf =================================================================== --- clang-tools-extra/pseudo/lib/cxx.bnf +++ clang-tools-extra/pseudo/lib/cxx.bnf @@ -409,7 +409,7 @@ noptr-declarator := noptr-declarator parameters-and-qualifiers noptr-declarator := noptr-declarator [ constant-expression_opt ] noptr-declarator := ( ptr-declarator ) -parameters-and-qualifiers := ( parameter-declaration-list_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt +parameters-and-qualifiers := ( parameter-declaration-clause_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt trailing-return-type := -> type-id ptr-operator := * cv-qualifier-seq_opt ptr-operator := &
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
