[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b16488129e: [X86] Fix some signedness errors in x86 headers (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427868. RKSimon added a comment. Remove superflouous cast from "_inc_ssp" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:37 static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) { - __builtin_ia32_incsspd((int)__a); + __builtin_ia32_incsspd((unsigned int)__a); } pengfei wrote: > Unnecessary

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > These intrinsics are interesting. The descriptions on Intrinsic guide are for > immediate variant, but all compilers' implementations are register variant. > What's more, the codegen from Clang and GCC don't seem correct according to > the description of `vpsrlw zmm0

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. In D125164#3498752 , @RKSimon wrote: > Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ > intrinsics return unsigned so we'd still end up with adding explicit casts No problem, adding explicit casts lo

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > What do you want to do about _mm512_maskz_srli_epi16 ? The Intel Intrinsic > guide has the same mismatch. These intrinsics are interesting. The descriptions on Intrinsic guide are for immediate variant, but all compilers' implementations are register variant. What's

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427863. RKSimon added a comment. Move the exhaustive headers checks into x86-intrinsics-headers-clean.cpp as that's what its for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.o

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427860. RKSimon added a comment. Fix signedness on 32-bit cet tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h clan

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ intrinsics return unsigned so we'd still end up with adding explicit casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://revie

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. In D125164#3498723 , @pengfei wrote: > One question: is it better to change the define of builtins than explicit > casts? I can fix the signedness of the cet / rdseed / xbgen / tzcnt x86 builtins if there's a consensus. What d

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. One question: is it better to change the define of builtins than explicit casts? Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a)

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a); @pengfei The Intel Intrisics guide has this taking a int ?

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427844. RKSimon added a comment. Remove a couple of superfluous casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h cl

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Another step toward enabling -Wsystem-headers testing across all x86 headers