This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c
failure (authored by thopre).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125084/new/
https:/
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125084/new/
https://reviews.llvm.org/D125084
thopre updated this revision to Diff 430029.
thopre marked an inline comment as done.
thopre added a comment.
Be more conservative in what we reject
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125084/new/
https://reviews.llvm.org/D125084
Files:
pengfei added inline comments.
Comment at: clang/test/Driver/x86-target-features.c:173
// LVIHARDENING: "-target-feature" "+lvi-load-hardening" "-target-feature"
"+lvi-cfi"
-// NO-LVIHARDENING-NOT: lvi
+// NO-LVIHARDENING-NOT: "-target-feature" "+lvi
How abou
thopre added a comment.
Ping?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125084/new/
https://reviews.llvm.org/D125084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
thopre created this revision.
thopre added reviewers: sconstab, craig.topper, andrew.w.kaylor, zbrid,
chandlerc.
Herald added subscribers: StephenFan, pengfei.
Herald added a project: All.
thopre requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commi
