pengfei added inline comments.
================ Comment at: clang/test/Driver/x86-target-features.c:173 // LVIHARDENING: "-target-feature" "+lvi-load-hardening" "-target-feature" "+lvi-cfi" -// NO-LVIHARDENING-NOT: lvi +// NO-LVIHARDENING-NOT: "-target-feature" "+lvi ---------------- How about just `// NO-LVIHARDENING-NOT: "+lvi-`? It should be distinct enough. We intentionally use less combination on a negative test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
