[PATCH] D124983: [HLSL] add -fcgl option flag.

2022-05-06 Thread Xiang Li via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa5eb4cfc06: [HLSL] add -fcgl option flag. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D124983: [HLSL] add -fcgl option flag.

2022-05-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124983/new/ https://reviews.llvm.org/D124983 ___ cfe-commits mailing list cfe-comm

[PATCH] D124983: [HLSL] add -fcgl option flag.

2022-05-06 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 427656. python3kgae added a comment. Remove HelpText for alias option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124983/new/ https://reviews.llvm.org/D124983 Files: clang/include/clang/Driver/Options

[PATCH] D124983: [HLSL] add -fcgl option flag.

2022-05-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a tiny nit. Comment at: clang/include/clang/Driver/Options.td:6768-6769 + "Same as -S + -emit-llvm + -disable-llvm-passes.">; +def fcg

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-06 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 427544. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add emit_pristine_llvm to make fcgl easier to understand. Also change unit test to lib test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-05 Thread Xiang Li via Phabricator via cfe-commits
python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; beanz wrote: > aaron.ball

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-05 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; aaron.ballman wrote: > Any partic

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; Any particular reason for

[PATCH] D124983: [HLSL} add -fcgl option flag.

2022-05-04 Thread Xiang Li via Phabricator via cfe-commits
python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M