This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG87a55137e2a2: Fix "the the" typo in documentation
and user facing strings (authored by briantracy, committed by Mordante).
Repository:
rG LLVM Git
ldionne accepted this revision.
ldionne added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124708/new/
https://reviews.llvm.org/D124708
___
cfe-commits mailing list
cfe-commits@lists.
briantracy marked an inline comment as done.
briantracy added a comment.
Thank you Mark and Gabor. At your discretion, could you commit this on my
behalf? My email is "brian.trac...@gmail.com" and full name is "Brian Tracy".
Thanks again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
martong accepted this revision.
martong added a comment.
Herald added a subscriber: rnkovacs.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124708/new/
https://reviews.llvm.org/D124708
___
cfe-commi
Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.
I see some test time-outs, but they seem to happen quite often.
LGTM, but please wait a few days before landing this patch to give other
reviewers time to have a look.
Repository:
rG LL
briantracy updated this revision to Diff 426259.
briantracy added a comment.
Updated sanitizer tests to include newly fixed error message strings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124708/new/
https://reviews.llvm.org/D124708
Files:
Mordante added a comment.
Thanks for these fixes. SGTM, but I want to see the CI pass.
Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:135
FD->getNameForDiagnostic(Out, FD->getASTContext().getLangOpts(), true);
- Out << "' call may invalidat
briantracy created this revision.
briantracy added a reviewer: echristo.
Herald added subscribers: martong, kerbowa, hiraditya, jvesely.
Herald added a project: All.
briantracy requested review of this revision.
Herald added projects: clang, libc++, LLVM.
Herald added subscribers: llvm-commits, lib
