Mordante added a comment. Thanks for these fixes. SGTM, but I want to see the CI pass.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:135 FD->getNameForDiagnostic(Out, FD->getASTContext().getLangOpts(), true); - Out << "' call may invalidate the the result of the previous " << '\''; + Out << "' call may invalidate the result of the previous " << '\''; FD->getNameForDiagnostic(Out, FD->getASTContext().getLangOpts(), true); ---------------- I'm not familiar with the static analyzers, so I don't know whether this breaks a test. I see the pre-commit CI couldn't apply your patch. Can you rebase this patch on main so the CI runs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124708/new/ https://reviews.llvm.org/D124708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits