[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 426185. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > ken-matsui wrote: > > aaron.ballman wrote: > > > I speculate that this

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { ken-matsui wrote: > aaron.ballman wrote: > > I speculate that this change is wrong. > > >

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > I speculate that this change is wrong. > > The goal here is to diagno

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added a comment. In D124534#3481264 , @ken-matsui wrote: > Hi, @aaron.ballman > > Thanks for your kind reviews! > I’ve updated the code, but is this what you’d expected? It looks like the precommit CI pipeline can't test your patch -- I th

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. Hi, @aaron.ballman Thanks for your kind reviews! I’ve updated the code, but is this what you’d expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 __

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 425916. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:431 +def ext_pp_gnu_line_directive : Extension< + "this style of line directive is a GNU extension">; + Oops, I missed this last time around, but we need this to be