This revision was automatically updated to reflect the committed changes.
Closed by commit rG043e96502408: [clangd] Add inlay hints for mutable reference
parameters (authored by upsj, committed by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
upsj updated this revision to Diff 426372.
upsj marked an inline comment as done.
upsj added a comment.
remove unnecessary annotation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D124359
Files:
clang-tools-e
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
Final nit: please update the commit message as it's a bit out of date, and then
I'll go ahead and merge
Comment at: clang-tools-extra/clangd/unittests/InlayHintTest
upsj updated this revision to Diff 426346.
upsj marked an inline comment as done.
upsj added a comment.
add test for const ref inlay hint via type alias
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D124359
Fil
upsj updated this revision to Diff 426344.
upsj added a comment.
right, arcanist doesn't entirely match my git mental model. Here's the
(hopefully) complete patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D
nridge added a comment.
Thanks, the changes here look good.
Something is strange about the diff though, it's not letting me see the
complete changes relative to the baseline, only the incremental changes
relative to a previous version (I think this is also why Phabricator's build
status says p
upsj added a comment.
Thanks, on second thought moving the hint to the prefix also makes more sense
to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D124359
___
upsj updated this revision to Diff 426343.
upsj marked 4 inline comments as done.
upsj added a comment.
address review comments: Move reference hint to the prefix, test type aliases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://
nridge requested changes to this revision.
nridge added a comment.
This revision now requires changes to proceed.
Apologies for the slow response here. This generally looks good to me, but I
have a couple of suggestions regarding the formatting of the hints and handling
type aliases.
upsj updated this revision to Diff 426217.
upsj added a comment.
don't add reference inlay hints for r-value refs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D124359
Files:
clang-tools-extra/clangd/InlayHin
upsj added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:448-450
+return Type->isReferenceType() &&
+ !Type.getNonReferenceType().isConstQualified()
+ ? (Type->isLValueReferenceType() ? "&" : "&&")
It pro
upsj updated this revision to Diff 425432.
upsj added a comment.
add tests for reference inlay hints
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/new/
https://reviews.llvm.org/D124359
Files:
clang-tools-extra/clangd/InlayHints.cpp
clan
nridge added a comment.
Thanks for working on this!
Could you add some test cases to [InlayHintTests.cpp] to illustrate the new
hint please?
As in the other patch, uploading the patch with context would also be helpful
for review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124359/
upsj created this revision.
upsj added a reviewer: nridge.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
upsj requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Add a &
14 matches
Mail list logo
