[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

This revision was automatically updated to reflect the committed changes. Closed by commit rG56058b921bd9: [clangd] Output inlay hints with `clangd --check` (authored by upsj, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj added a comment. @nridge Please do, I don't have commit permissions :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 ___ cfe-commits mailing list cfe-com

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge added a comment. Let me know if you'd like me to commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 ___ cfe-commits mailing list c

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424846. upsj added a comment. - use string literal for toString result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 Files: clang-tools-extra/clangd/Protocol.cpp c

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

sammccall added a comment. (LGTM too, thanks!) Comment at: clang-tools-extra/clangd/Protocol.cpp:1319 -llvm::json::Value toJSON(InlayHintKind K) { +const char *toString(InlayHintKind K) { switch (K) { nit: static (this doesn't need to be public) nit: retur

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424839. upsj added a comment. push full patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-extra/clangd/P

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424838. upsj added a comment. Review updates - Fix inverted check-lines condition - Output InlayHintKind via ostream operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D1

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424836. upsj marked 2 inline comments as done. upsj added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 Files: clang-tools-extra/clangd/Protocol.

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

kadircet added a comment. can you please upload the patch with full context? see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang-tools-extra/clangd/tool/Check.cpp:196 + // Build Inlay Hints for the entire AST or the specified

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:201 +for (const auto &Hint : Hints) { + vlog(" {0} {1}", Hint.position, Hint.label); +} upsj wrote: > nridge wrote: > > Might be useful for print the hint kind as well

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj marked 2 inline comments as done. upsj added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:195 + // Build Inlay Hints for the entire AST + bool buildInlayHints(llvm::Optional LineRange) { nridge wrote: > The comment should probably

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424817. upsj added a comment. forgot to include the old changes in the diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-extra/clangd/Protocol.h

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj updated this revision to Diff 424816. upsj added a comment. Output InlayHintKind and improve comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-extra/clangd/Protocol.h c

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, this seems useful. Comment at: clang-tools-extra/clangd/tool/Check.cpp:195 + // Build Inlay Hints for the entire AST + bool buildInlayHints(llvm::Optional LineRan

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

upsj created this revision. upsj added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. With