sammccall added a comment. (LGTM too, thanks!)
================ Comment at: clang-tools-extra/clangd/Protocol.cpp:1319 -llvm::json::Value toJSON(InlayHintKind K) { +const char *toString(InlayHintKind K) { switch (K) { ---------------- nit: static (this doesn't need to be public) nit: return llvm::StringLiteral (which includes the length) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits