[PATCH] D124199: [randstruct] Check final randomized layout ordering

DavidSpickett added a comment. We (Linaro) also got the same failure: https://lab.llvm.org/buildbot/#/builders/186/builds/5626 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Reverted in 8dbc6b560055ff5068ff45b550482ba62c36b5a5 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124199: [randstruct] Check final randomized layout ordering

MaskRay added a comment. In D124199#3466653 , @void wrote: > Maskray? I think this is likely the failure I saw when I tried fix forward in 46b2a463bdef1bd1d80abee869b09f95ca5a4fc2 .

Re: [PATCH] D124199: [randstruct] Check final randomized layout ordering

Maskray? On Thu, Apr 21, 2022 at 8:00 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/56771/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > > Repos

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56771/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.ll

[PATCH] D124199: [randstruct] Check final randomized layout ordering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7815d33bf8f: [randstruct] Check final randomized layout ordering (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void updated this revision to Diff 424357. void added a comment. Fixed "std::vector" mishap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199 Files: clang/lib/AST/Randstruct.cpp clang/unittests/AST/Rand

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:153 - std::shuffle(std::begin(Buckets), std::end(Buckets), RNG); + llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG); MaskRay wrote: > This was my original fix and your reland dro

[PATCH] D124199: [randstruct] Check final randomized layout ordering

MaskRay added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:153 - std::shuffle(std::begin(Buckets), std::end(Buckets), RNG); + llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG); This was my original fix and your reland dropped it :( =

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This uses "llvm::shuffle" to stop differences