MaskRay added inline comments.

================
Comment at: clang/lib/AST/Randstruct.cpp:153
 
-  std::shuffle(std::begin(Buckets), std::end(Buckets), RNG);
+  llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG);
 
----------------
This was my original fix and your reland dropped it :(


================
Comment at: clang/unittests/AST/RandstructTest.cpp:359
         &AST->getASTContext().getASTRecordLayout(RD);
+    const std::vector Expected = {"c", "b", "a"};
 
----------------
We haven't used c++17 yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124199/new/

https://reviews.llvm.org/D124199

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to